Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form-field): deprecate legacy and standard appearances #17961

Merged
merged 1 commit into from Dec 14, 2019
Merged

fix(form-field): deprecate legacy and standard appearances #17961

merged 1 commit into from Dec 14, 2019

Conversation

mmalerba
Copy link
Contributor

BREAKING CHANGES:

  • The legacy and standard appearance options for MatFormField are
    now deprecated

@mmalerba
fix(form-field): deprecate legacy and standard appearances
dd6d5be 
BREAKING CHANGES:
- The `legacy` and `standard` appearance options for `MatFormField` are
now deprecated
@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 13, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Dec 13, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2019
jelbourn
jelbourn approved these changes Dec 14, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 14, 2019
@mmalerba mmalerba merged commit 527f1b5 into angular:master Dec 14, 2019
@mmalerba mmalerba deleted the deprecate-standard branch December 14, 2019 03:47
@Splaktar Splaktar mentioned this pull request Jan 9, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmalerba @jelbourn @googlebot