Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/form-field): undeprecated legacy and standard appearances #18144

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@mmalerba
Copy link
Contributor

mmalerba commented Jan 9, 2020

There are a few bugs to address with outline and fill styles before we
can deprecate these.

There are a few bugs to address with outline and fill styles before we
can deprecate these.
@mmalerba mmalerba added this to the 9.0.0 milestone Jan 9, 2020
@mmalerba mmalerba requested review from Splaktar and crisbeto Jan 9, 2020
@googlebot googlebot added the cla: yes label Jan 9, 2020
Copy link
Member

Splaktar left a comment

LGTM

@Splaktar

This comment has been minimized.

Copy link
Member

Splaktar commented Jan 9, 2020

Reverts PR #17961.

Copy link
Member

devversion left a comment

I think we should write down what the plan for the MDC version is. Surely, it will be on the list to ensure that the alignment issues are solved, but since this will shift the deprecation, the MDC form-field either needs to wait until we can make this breaking change, or we need to provide a standard/legacy implementation?

@mmalerba

This comment has been minimized.

Copy link
Contributor Author

mmalerba commented Jan 13, 2020

CARETAKER NOTE: cherrypick into 9.0.x branch

@andrewseguin andrewseguin merged commit d550e4e into angular:master Jan 15, 2020
12 checks passed
12 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
andrewseguin added a commit that referenced this pull request Jan 15, 2020
#18144)

There are a few bugs to address with outline and fill styles before we
can deprecate these.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.