fix(material/autocomplete): Prevent Autocomplete overlap with outlined form-field label when overlay is positioned above #27714
Conversation
kharazian
requested review from
devversion,
mmalerba and
crisbeto
as code owners
| * Calculate the vertical offset for the overlay when the input field has an outline appearance. | ||
| * In the outline appearance, the overlay should have extra space to display the label correctly. | ||
| */ | ||
| const outlineHeight = |
There was a problem hiding this comment.
This logic will measure the floating label height even if the form field isn't using the outlined appearance. This should be guarded with the hasOutline check since it has performance implications.
There was a problem hiding this comment.
Thank you for pointing out the need to optimize this logic. I've first checked _hasOutline() to enhance performance when measuring the floating label height in cases where the form field isn't using the outlined appearance.
| // border-radius based on the overlay position. | ||
| const panelClass = this._aboveClass; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Should use the // style comments.
There was a problem hiding this comment.
Thank you, I've made the correction.
kharazian
force-pushed
the
calculate-overlay-offset-for-outlined-input-fields
branch
from
c6f883c to
8f1b1b3
Compare
…d label when overlay above Fixes by preventing Autocomplete overlap with outlined form-field label when overlay is positioned above. Implemente a function to calculate the necessary vertical offset for outlined appearance, ensuring label legibility. Fixes angular#27476
…ing parent form field Fixes angular#27476
…he outline appearance Fixes angular#27476
mmalerba
force-pushed
the
calculate-overlay-offset-for-outlined-input-fields
branch
from
8f1b1b3 to
1490253
Compare
mmalerba
added
the
dev-app preview
|
Deployed dev-app for 1490253 to: https://ng-dev-previews-comp--pr-angular-components-27714-dev-eewx7wsq.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Fixed by preventing Autocomplete overlap with outlined form-field label when overlay is positioned above. Implemented a function to calculate the necessary vertical offset for outlined appearance, ensuring label legibility.
Fix #27476