Skip to content

fix(material/autocomplete): Prevent Autocomplete overlap with outlined form-field label when overlay is positioned above #27714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(material/autocomplete): Prevent Autocomplete overlap with outlined form-field label when overlay is positioned above #27714

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
005ceb9
fix(material/autocomplete): prevent autocomplete overlap with outline…
kharazian Aug 26, 2023
f88a792
fix(material/autocomplete): enhanced offset determination by consider…
kharazian Aug 27, 2023
1490253
fix(material/autocomplete): optimized performance by first checking t…
kharazian Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/material/autocomplete/autocomplete-trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,9 +924,24 @@ export class MatAutocompleteTrigger
// the opposite end has rounded corners. We apply a CSS class to swap the
// border-radius based on the overlay position.
const panelClass = this._aboveClass;

// Calculate the vertical offset for the overlay when the input field has an outline appearance.
// In the outline appearance, the overlay should have extra space to display the label correctly.
let offsetY = 0;
if (this._formField?._hasOutline()) {
offsetY = -(this._formField?._floatingLabel?.element.getBoundingClientRect().height || 0) / 2;
}

const abovePositions: ConnectedPosition[] = [
{originX: 'start', originY: 'top', overlayX: 'start', overlayY: 'bottom', panelClass},
{originX: 'end', originY: 'top', overlayX: 'end', overlayY: 'bottom', panelClass},
{
originX: 'start',
originY: 'top',
overlayX: 'start',
overlayY: 'bottom',
panelClass,
offsetY,
},
{originX: 'end', originY: 'top', overlayX: 'end', overlayY: 'bottom', panelClass, offsetY},
];

let positions: ConnectedPosition[];
Expand Down
Loading