fix(cdk/accordion): improve accessibility in example code #30087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sepandard
requested review from
crisbeto and
amysorto
and removed request for
a team
crisbeto
approved these changes
Nov 27, 2024
| Click to {{ accordionItem.expanded ? 'close' : 'open' }} | ||
| </span> | ||
| </button> | ||
| @if(accordionItem.expanded){ |
There was a problem hiding this comment.
nit: the formatting is off here
There was a problem hiding this comment.
I fix formatting problem in if statement. @crisbeto
Sepandard
force-pushed
the
fix-cdk-accordion-accessibility-example
branch
from
084bcba to
543b356
Compare
Updated the example code for the CDK accordion component to address accessibility issues resolves angular#30041
Sepandard
force-pushed
the
fix-cdk-accordion-accessibility-example
branch
from
543b356 to
3f44146
Compare
crisbeto
added
action: merge
crisbeto
pushed a commit
that referenced
this pull request
Nov 29, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the example code for the CDK accordion component to address accessibility issues
resolves #30041