Skip to content

fix(cdk/accordion): improve accessibility in example code #30087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix(cdk/accordion): improve accessibility in example code #30087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...mponents-examples/cdk/accordion/cdk-accordion-overview/cdk-accordion-overview-example.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,21 @@

.example-accordion-item-header {
display: flex;
align-content: center;
align-items: center;
justify-content: space-between;
width: 100%;
background: none;
border: none;
padding: 16px;
text-align: left;

}

.example-accordion-item-description {
font-size: 0.85em;
color: #999;
}

.example-accordion-item-header,
.example-accordion-item-body {
padding: 16px;
}
Expand Down
46 changes: 23 additions & 23 deletions ...ponents-examples/cdk/accordion/cdk-accordion-overview/cdk-accordion-overview-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,31 @@
<cdk-accordion class="example-accordion">
@for (item of items; track item; let index = $index) {
<cdk-accordion-item

#accordionItem="cdkAccordionItem"
class="example-accordion-item"
role="button"
<cdk-accordion-item #accordionItem="cdkAccordionItem" class="example-accordion-item">
<button
class="example-accordion-item-header"
(click)="accordionItem.toggle()"
tabindex="0"
[attr.id]="'accordion-header-' + index"
[attr.aria-expanded]="accordionItem.expanded"
[attr.aria-controls]="'accordion-body-' + index">
<div class="example-accordion-item-header" (click)="accordionItem.toggle()">
{{ item }}
<span class="example-accordion-item-description">
Click to {{ accordionItem.expanded ? 'close' : 'open' }}
</span>
</div>
<div
class="example-accordion-item-body"
role="region"
[style.display]="accordionItem.expanded ? '' : 'none'"
[attr.id]="'accordion-body-' + index"
[attr.aria-labelledby]="'accordion-header-' + index">
Lorem ipsum dolor, sit amet consectetur adipisicing elit. Perferendis
excepturi incidunt ipsum deleniti labore, tempore non nam doloribus blanditiis
veritatis illo autem iure aliquid ullam rem tenetur deserunt velit culpa?
</div>
</cdk-accordion-item>
{{ item }}
<span class="example-accordion-item-description">
Click to {{ accordionItem.expanded ? 'close' : 'open' }}
</span>
</button>
@if(accordionItem.expanded) {
<div
class="example-accordion-item-body"
role="region"
[style.display]="accordionItem.expanded ? '' : 'none'"
[attr.id]="'accordion-body-' + index"
[attr.aria-labelledby]="'accordion-header-' + index"
>
Lorem ipsum dolor, sit amet, consectetur adipisicing elit. Perferendis excepturi incidunt ipsum
deleniti labore, tempore non nam doloribus blanditiis veritatis illo autem iure aliquid ullam
rem tenetur deserunt velit culpa?
</div>
}
</cdk-accordion-item>
}
</cdk-accordion>

Loading