Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 28, 2025

Reworks a menu test so that it doesn't depend on the NoopAnimationsModule anymore.

@crisbeto crisbeto requested a review from a team as a code owner August 28, 2025 07:11
@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Aug 28, 2025
@crisbeto crisbeto requested review from adolgachev and ok7sai and removed request for a team August 28, 2025 07:11
@crisbeto crisbeto force-pushed the menu-destroy-focus-restoration branch from 26590c0 to 0660998 Compare August 28, 2025 13:11
Reworks a menu test so that it doesn't depend on the `NoopAnimationsModule` anymore.
@crisbeto crisbeto force-pushed the menu-destroy-focus-restoration branch from 0660998 to 4aa9b03 Compare August 28, 2025 14:36
@crisbeto crisbeto changed the title fix(material/menu): moving focus on destroy not working without animations module test(material/menu): remove NoopAnimationsModule usage Aug 28, 2025
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 29, 2025
@crisbeto crisbeto merged commit c5f9a60 into angular:main Aug 29, 2025
24 of 25 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/menu target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants