Skip to content

test(material/menu): remove NoopAnimationsModule usage #31800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

test(material/menu): remove NoopAnimationsModule usage #31800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/material/menu/menu.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import {
} from '@angular/core';
import {ComponentFixture, fakeAsync, flush, TestBed, tick} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
import {Subject} from 'rxjs';
import {
createKeyboardEvent,
Expand Down Expand Up @@ -256,10 +255,6 @@ describe('MatMenu', () => {
}));

it('should move focus to another item if the active item is destroyed', fakeAsync(() => {
// TODO(crisbeto): figure out why NoopAnimationsModule is necessary
// here and our token isn't enough. Likely indicates an issue.
TestBed.resetTestingModule().configureTestingModule({imports: [NoopAnimationsModule]});
overlayContainerElement = TestBed.inject(OverlayContainer).getContainerElement();
const fixture = TestBed.createComponent(MenuWithRepeatedItems);
fixture.detectChanges();
const triggerEl = fixture.componentInstance.triggerEl.nativeElement;
Expand All @@ -268,17 +263,19 @@ describe('MatMenu', () => {
fixture.detectChanges();
tick(500);

const items = overlayContainerElement.querySelectorAll(
const items = overlayContainerElement.querySelectorAll<HTMLElement>(
'.mat-mdc-menu-panel .mat-mdc-menu-item',
);

expect(document.activeElement).toBe(items[0]);
// Stub out the `_hasFocus` method since it's hard to move focus reliably within the test.
spyOn(fixture.componentInstance.itemInstances.first, '_hasFocus').and.callFake(() => true);
const spy = spyOn(items[1], 'focus');

fixture.componentInstance.items.shift();
fixture.detectChanges();
tick(500);

expect(document.activeElement).toBe(items[1]);
expect(spy).toHaveBeenCalled();
}));

it('should be able to set a custom class on the backdrop', fakeAsync(() => {
Expand Down Expand Up @@ -3027,5 +3024,6 @@ class MenuWithRepeatedItems {
@ViewChild(MatMenuTrigger, {static: false}) trigger: MatMenuTrigger;
@ViewChild('triggerEl', {static: false}) triggerEl: ElementRef<HTMLElement>;
@ViewChild(MatMenu, {static: false}) menu: MatMenu;
@ViewChildren(MatMenuItem) itemInstances: QueryList<MatMenuItem>;
items = ['One', 'Two', 'Three'];
}
Loading