fix(cdk-experimental/accordion): creates visually hidden span to improve screen reader accessibility #31804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
added
the
dev-app preview
|
Deployed dev-app for 3b5b3a2 to: https://ng-dev-previews-comp--pr-angular-components-31804-dev-ewlwd9xn.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
force-pushed
the
add-proper-description-for-disabled-region
branch
from
7901e82 to
21ceb3c
Compare
…ove screen reader accessibility Adds a visually hidden span as a child of the accordion header/button which has a generated id for the associated accordion content panel to reference if/when the accordion header/button is disabled. This should allow screen readers to have an active reference for aria-labelledby to reference. Fixes b/438312273
…ccordion trigger parent element Updates previous change to move the visually hidden span from being a child of the accordion trigger button, to being a child of the parent wrapping the accordion trigger. This prevents it from being hidden by aria-disabled or disabled attributes when being a child of the trigger.
…den span Updates previous fix to add tabindex -1 to make the visually hidden span not focusable.
… accurately Updates previous changes to implement disabled and expanded states of the accordion trigger button to the visually hidden label to ensure the exact state of the button is communicated to the screen reader. Also updates previous change to pass the visuallyHiddenId to the AccordionTriggerPattern as recommended by Cheng. These updates should improve id consistency as well as an improved label which fully describes the accordion trigger state to screen readers.
essjay05
force-pushed
the
add-proper-description-for-disabled-region
branch
from
abbd8d4 to
177869d
Compare
Updates previous changes to fix lint errors.
Updates previous change by removing hardcoded strings.
|
Solution provided in #31817 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a visually hidden span as a child of the accordion header/button which has a generated id for the associated accordion content panel to reference if/when the accordion header/button is disabled. This should allow screen readers to have an active reference for aria-labelledby to reference.
Fixes b/438312273