fix(cdk-experimental/accordion): removes inert attribute from accordion trigger #31817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
added
the
dev-app preview
|
Deployed dev-app for 5b4c1de to: https://ng-dev-previews-comp--pr-angular-components-31817-dev-zw5u7i9a.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
requested review from
mmalerba and
andrewseguin
and removed request for
a team
ok7sai
approved these changes
Sep 3, 2025
…on trigger Updates accordion trigger attributes by removing the inert attribute to allow for screen readers to reference the aria-labelledby id value of the trigger when associating it with the accordion content panel. Fixes b/438312273
…cordion trigger Updates previous fix to remove the inert attribute from the accordion trigger after confirming using the dev-app to test how the screen reader announces the disabled trigger with its associated expanded panel.
essjay05
force-pushed
the
disabled-accordion-remove-inert-attr
branch
from
9af7554 to
5b4c1de
Compare
adolgachev
requested review from
wagnermaciel and
adolgachev
and removed request for
andrewseguin
adolgachev
approved these changes
Sep 5, 2025
|
LGTM - just please make sure to rebase to just a single fix commit with the actual line removal. I added @wagnermaciel as FYI but you can just ping him and see if he has any other thoughts (and/oror remove him if already discussed) but seems like a great simple fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates accordion trigger attributes by removing the inert attribute to allow for screen readers to correctly reference the aria-labelledby id value of a disabled accordion trigger when associating it with a accordion content panel. Additionally, when moving focus to the disabled trigger, removing the inert attribute allows for the button's state to be announced (ie. disabled, collapsed/expanded).
Fixes b/438312273