Skip to content

Conversation

essjay05
Copy link
Contributor

@essjay05 essjay05 commented Sep 3, 2025

Updates accordion trigger attributes by removing the inert attribute to allow for screen readers to correctly reference the aria-labelledby id value of a disabled accordion trigger when associating it with a accordion content panel. Additionally, when moving focus to the disabled trigger, removing the inert attribute allows for the button's state to be announced (ie. disabled, collapsed/expanded).

Fixes b/438312273

@essjay05 essjay05 added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Sep 3, 2025
Copy link

github-actions bot commented Sep 3, 2025

Deployed dev-app for c9137b5 to: https://ng-dev-previews-comp--pr-angular-components-31817-dev-zw5u7i9a.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@essjay05 essjay05 marked this pull request as ready for review September 3, 2025 19:44
@essjay05 essjay05 requested a review from a team as a code owner September 3, 2025 19:44
@essjay05 essjay05 requested review from mmalerba and andrewseguin and removed request for a team September 3, 2025 19:44
@adolgachev
Copy link
Contributor

adolgachev commented Sep 5, 2025

LGTM - just please make sure to rebase to just a single fix commit with the actual line removal.

I added @wagnermaciel as FYI but you can just ping him and see if he has any other thoughts (and/oror remove him if already discussed) but seems like a great simple fix. Thanks!

@essjay05 essjay05 force-pushed the disabled-accordion-remove-inert-attr branch from 5b4c1de to 5923f20 Compare September 8, 2025 15:42
@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Sep 8, 2025
@essjay05 essjay05 force-pushed the disabled-accordion-remove-inert-attr branch 2 times, most recently from 20fd9a6 to 58345bb Compare September 8, 2025 17:05
…on trigger

Updates accordion trigger attributes by removing the inert
attribute to allow for screen readers to reference the
aria-labelledby id value of the trigger when associating
it with the accordion content panel.

Fixes b/438312273

fix(cdk-experimental/accordion): removes inert attribute from accordion trigger

Removes the inert attribute from accordion trigger to enable screen
readers to access the accordion trigger id and aria attributes to be
able to announce more helpful/informative screen reader messages to the
user.

Fixes b/438312273
@essjay05 essjay05 force-pushed the disabled-accordion-remove-inert-attr branch from 58345bb to c9137b5 Compare September 8, 2025 17:27
@adolgachev adolgachev merged commit f137183 into angular:main Sep 8, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants