Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): remove overflow hidden from content #4426

Merged
merged 1 commit into from May 11, 2017

Conversation

devversion
Copy link
Member

  • Removes the overflow: hidden on the list-items by moving the ripples into a child element that overlays the content.

Fixes #4156

* Removes the `overflow: hidden` on the list-items by moving the ripples into a child element that overlays the content.

Fixes angular#4156
@devversion devversion requested a review from jelbourn May 8, 2017 15:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 8, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 10, 2017
@kara kara merged commit 078aa19 into angular:master May 11, 2017
@devversion devversion deleted the fix/list-overflow-hidden branch May 13, 2017 09:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disableRipple on list item leaves ripple class with overflow:hidden side effect
4 participants