chore(): change all components to onPush detection #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Interesting. LGTM. |
|
Question: is it only for this component or also for its content components? |
|
@hansl It applies to the the component's view but not its content. |
Closed
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
* regen filkes * Fix firebase not loading example sources
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @hansl @kara
CC: @robertmesserle
This is something I'd forgot to mention earlier. The general idea here is that the
onPushstrategy tells Angular to only check the component and its view children when either one of its@Inputproperties change or when an event is handled. For components that only bind either primitives or immutable objects, this should "just work" and speed up change detection. As far as I can tell, all of the components so far just bind primitives (or nothing at all, for cards).