Skip to content

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Sep 12, 2017

Addresses #6677 for Chips

Changes:

  • select to selectionChange
  • deselect to deselected - @jelbourn - what do you think about making this deselection?
  • destroy to destroyed
  • remove to removed

@amcdnl amcdnl self-assigned this Sep 12, 2017
@amcdnl amcdnl requested a review from jelbourn September 12, 2017 22:24
@amcdnl amcdnl requested a review from tinayuangao as a code owner September 12, 2017 22:24
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 12, 2017
@amcdnl amcdnl removed the request for review from tinayuangao September 12, 2017 22:24
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just having selectionChange capture both selected and deselected?

@willshowell
Copy link
Contributor

These selection list changes are probably relevant: #6901

@amcdnl
Copy link
Contributor Author

amcdnl commented Sep 14, 2017

@jelbourn - I like that much better. Updated. What about removed, can that go?

@jelbourn
Copy link
Member

removed should stay AFAIK- why would you want to get rid of it?

@amcdnl
Copy link
Contributor Author

amcdnl commented Sep 17, 2017

@jelbourn - It was unclear to me how it differs from delected.

@tinayuangao
Copy link
Contributor

@amcdnl could you please rebase?

@amcdnl
Copy link
Contributor Author

amcdnl commented Sep 18, 2017

This has diverged so much, I'm going to redo this in a new PR.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants