Skip to content

chore(api): update chip api #6677 #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2017
Merged

chore(api): update chip api #6677 #7156

merged 1 commit into from
Sep 20, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Sep 18, 2017

Addressees #6677, supersedes #7030

Changes:

  • onSelectionChange to selectionChange
  • destroy to destroyed
  • remove to removed

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 18, 2017
jelbourn
jelbourn approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 19, 2017
tinayuangao
tinayuangao approved these changes Sep 19, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit fdf68ba into angular:master Sep 20, 2017
@amcdnl amcdnl deleted the chips-output-6677 branch September 21, 2017 21:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

+1 more reviewer

@tinayuangao tinayuangao tinayuangao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amcdnl @jelbourn @tinayuangao @googlebot