Skip to content

Commit ae5a9cb

Browse files
committed
fix(bazel): include package.json for api_golden_test_npm_package runs to ensure it runs in commonjs (#2992)
PR Close #2992
1 parent 19f74a9 commit ae5a9cb

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

bazel/api-golden/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ package(default_visibility = ["//visibility:public"])
55
exports_files([
66
"index.ts",
77
"index_npm_packages.cts",
8+
"package.json",
89
])
910

1011
ts_project(

bazel/api-golden/api_golden_test_npm_package.bzl

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@ def api_golden_test_npm_package(
3030

3131
kwargs["tags"] = kwargs.get("tags", []) + ["api_guard"]
3232

33-
data.append("@devinfra//bazel/api-golden")
33+
data.extend([
34+
"@devinfra//bazel/api-golden",
35+
"@devinfra//bazel/api-golden:package.json",
36+
])
3437

3538
types_name_and_path = []
3639
for label, n in types.items():
@@ -46,6 +49,9 @@ def api_golden_test_npm_package(
4649
name = name,
4750
data = data,
4851
entry_point = "@devinfra//bazel/api-golden:index_npm_packages.cjs",
52+
no_copy_to_bin = [
53+
"@devinfra//bazel/api-golden:package.json",
54+
],
4955
args = [golden_dir, npm_package, "false", quoted_export_pattern] + types_name_and_path,
5056
**kwargs
5157
)
@@ -54,6 +60,9 @@ def api_golden_test_npm_package(
5460
name = name + ".accept",
5561
testonly = True,
5662
data = data,
63+
no_copy_to_bin = [
64+
"@devinfra//bazel/api-golden:package.json",
65+
],
5766
entry_point = "@devinfra//bazel/api-golden:index_npm_packages.cjs",
5867
args = [golden_dir, npm_package, "true", quoted_export_pattern] + types_name_and_path,
5968
**kwargs

bazel/api-golden/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"type": "commonjs"
3+
}

0 commit comments

Comments
 (0)