Skip to content

Commit b529efe

Browse files
fix(ng-dev): fix commitCheck functions for managed labels
Some of the managed labels were incorrectly looking at type rather than scope for their commitCheck function, which resulted in always failing to match.
1 parent 5b4b2a6 commit b529efe

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

ng-dev/pr/common/labels/managed.ts

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,31 @@ export const managedLabels = createTypedObject(ManagedLabel)({
4747
DETECTED_HTTP_CHANGE: {
4848
description: 'Issues related to HTTP and HTTP Client',
4949
name: 'area: common/http',
50-
commitCheck: (c: Commit) => c.type === 'common/http' || c.type === 'http',
50+
commitCheck: (c: Commit) => c.scope === 'common/http' || c.scope === 'http',
5151
repositories: [ManagedRepositories.ANGULAR],
5252
},
5353
DETECTED_COMPILER_CHANGE: {
5454
description: "Issues related to `ngc`, Angular's template compiler",
5555
name: 'area: compiler',
56-
commitCheck: (c: Commit) => c.type === 'compiler' || c.type === 'compiler-cli',
56+
commitCheck: (c: Commit) => c.scope === 'compiler' || c.scope === 'compiler-cli',
5757
repositories: [ManagedRepositories.ANGULAR],
5858
},
5959
DETECTED_PLATFORM_BROWSER_CHANGE: {
6060
description: 'Issues related to the framework runtime',
6161
name: 'area: core',
62-
commitCheck: (c: Commit) => c.type === 'platform-browser' || c.type === 'core',
62+
commitCheck: (c: Commit) => c.scope === 'platform-browser' || c.scope === 'core' || c.scope === 'platform-browser-dynamic',
63+
repositories: [ManagedRepositories.ANGULAR],
64+
},
65+
DETECTED_PLATFORM_SERVER_CHANGE: {
66+
description: 'Issues related to server-side rendering',
67+
name: 'area: server',
68+
commitCheck: (c: Commit) => c.scope === 'platform-server',
69+
repositories: [ManagedRepositories.ANGULAR],
70+
},
71+
DETECTED_ZONES_CHANGE: {
72+
description: 'Issues related to zone.js',
73+
name: 'area: zones',
74+
commitCheck: (c: Commit) => c.scope === 'zone.js',
6375
repositories: [ManagedRepositories.ANGULAR],
6476
},
6577
});

0 commit comments

Comments
 (0)