Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

mathieugeissler
Copy link
Contributor

When the id is a number and is equal to 0, don't return an error response

When the id is a number and is equal to 0, don't return an error response
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mathieugeissler mathieugeissler changed the title Bugfix : check id is unedfined Bugfix : check id is undefined Feb 21, 2017
@mathieugeissler
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@wardbell
Copy link
Contributor

wardbell commented May 2, 2017

Thanks. I had to resolve a merge conflict. Then I noticed that we need a similar test for get. Addressed both in my merge commit.

@wardbell wardbell merged commit 2328be5 into angular:master May 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants