Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Bugfix : check id is undefined #95

Merged
merged 2 commits into from
May 2, 2017
Merged

Bugfix : check id is undefined #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa66ac7
Bugfix : check id is unedfined
mathieugeissler Feb 21, 2017
26e35ae
Merge branch 'master' into patch-1
wardbell May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/in-memory-backend.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,9 @@ export class InMemoryBackendService {
return createObservableResponse(reqInfo.req, resOptions);
}

protected delete({ id, collection, collectionName, headers, req }: RequestInfo) {
if (!id) {
protected delete({id, collection, collectionName, headers, req}: RequestInfo) {
// tslint:disable-next-line:triple-equals
if (id == undefined) {
return createErrorResponse(req, STATUS.NOT_FOUND, `Missing "${collectionName}" id`);
}
const exists = this.removeById(collection, id);
Expand All @@ -517,10 +518,11 @@ export class InMemoryBackendService {
protected get({ id, query, collection, collectionName, headers, req }: RequestInfo) {
let data = collection;

if (id) {
data = this.findById(collection, id);
} else if (query) {
// tslint:disable-next-line:triple-equals
if (id == undefined) {
data = this.applyQuery(collection, query);
} else if (query) {
data = this.findById(collection, id);
}

if (!data) {
Expand Down