This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix(table): http example needs httpclientmodule #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a corresponding fix in material2 repo that this is generated from? |
|
Yeah this one here - angular/components@0ea4370#diff-c3b988af35d5ab4790e4795e2d7015dd |
Splaktar
approved these changes
Dec 21, 2017
| @@ -86,6 +87,7 @@ export class DemoMaterialModule {} | |||
| BrowserAnimationsModule, | |||
| FormsModule, | |||
| HttpModule, | |||
There was a problem hiding this comment.
Should we remove HttpModule?
There was a problem hiding this comment.
HttpModule will be removed everywhere in a different PR.
There was a problem hiding this comment.
Good call - let's cleanup in another PR. Would like to at least just make sure this fix goes in without the risk of breaking other examples if I miss a case of one using HttpModule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current example is broken since it requires the new Http module.
Fixes #339