Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

fix(table): http example needs httpclientmodule #352

Merged
merged 1 commit into from
Jan 18, 2018
Merged

fix(table): http example needs httpclientmodule #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/assets/stackblitz/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import {
} from '@angular/material';
import {MaterialDocsExample} from './app/material-docs-example';
import {HttpModule} from '@angular/http';
import {HttpClientModule} from '@angular/common/http';
import {CdkTableModule} from '@angular/cdk/table';

@NgModule({
Expand Down Expand Up @@ -86,6 +87,7 @@ export class DemoMaterialModule {}
BrowserAnimationsModule,
FormsModule,
HttpModule,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove HttpModule?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HttpModule will be removed everywhere in a different PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call - let's cleanup in another PR. Would like to at least just make sure this fix goes in without the risk of breaking other examples if I miss a case of one using HttpModule

HttpClientModule,
DemoMaterialModule,
MatNativeDateModule,
ReactiveFormsModule,
Expand Down