Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

feature/shadow-root-locator #4392

Closed
wants to merge 7 commits into from

Conversation

firstor
Copy link

@firstor firstor commented Jul 18, 2017

Implemented new Protractor locator to select elements inside shadow-root.
For the background: #4367

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@nickiannone
Copy link

Could we please address the CI issues? I'm missing a LOT of test coverage because of inability to test shadow DOM elements.

@firstor
Copy link
Author

firstor commented Jul 31, 2017

@nickiannone There seemed no error happened from by.shadowRoot side. I wrote a spec for shadowRoot locator and it passed the CircleCI test.

@whyboris
Copy link

whyboris commented Dec 13, 2017

Any update on this? Would be great to have ❤️

@firstor firstor force-pushed the feature/shadow-root-locator branch from 2894642 to 2b6e91d Compare January 23, 2018 12:38
@firstor
Copy link
Author

firstor commented Jan 23, 2018

I don't know why CircleCI build failed ~ I discard my changes and then tried again but it kept to fail.
Hope someone helps me resolve the following builds :

@dweill
Copy link

dweill commented Apr 5, 2018

@qiyigg
Copy link
Contributor

qiyigg commented Apr 14, 2018

To get circleCI work, you need rebase your PR to the latest version. Check(#4669)

@firstor firstor closed this Apr 21, 2018
@firstor firstor deleted the feature/shadow-root-locator branch April 21, 2018 13:29
@firstor firstor restored the feature/shadow-root-locator branch April 21, 2018 13:31
@firstor firstor deleted the feature/shadow-root-locator branch April 21, 2018 13:34
@firstor
Copy link
Author

firstor commented Apr 22, 2018

Moved to new PR #4786

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants