Skip to content

Conversation

schulz3000
Copy link

Add additional prefixes to Pascal and Bar

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason why Milli and Centi is left out? I don't know what prefixes are commonly used with Pascal.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course it's possible to convert it to Milli and Centi but I never see it in the wild. In my company we we are working lot with measuring of preasure. There I also never see a device that use MilliPascal or CentiPascal.
As source in the internet I only find a german wiki entry where you can also find these prefixes: http://de.wikipedia.org/wiki/Pascal_(Einheit)

@angularsen
Copy link
Owner

Ok, good enough for me.

You need to fix that compile error in the test project though. Basically implement the new test values in PressureTests.cs. The wiki on adding new units explains this for your reference.

Build log:
http://dev.swingcatalyst.com/TeamCity/viewLog.html?buildId=22246&buildTypeId=UnitsNet

Let me know when it's fixed and I'm ready to merge this in.

@schulz3000
Copy link
Author

@anjdreas Unittests are fixed

@angularsen
Copy link
Owner

Looks good, thanks!

angularsen added a commit that referenced this pull request May 15, 2015
Add pressure units
* Pascal prefixes: Micro,Deca,Hecto,Giga
* Bar prefixes: Milli,Centi,Deci,Kilo,Mega
@angularsen angularsen merged commit 165b5ff into angularsen:develop May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants