Skip to content

Conversation

mcgougwm
Copy link
Contributor

@mcgougwm mcgougwm commented Jun 9, 2021

Added Inverse Angle Units

@@ -0,0 +1,39 @@
{
"Name": "InverseAngle",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are some typical use cases for this quantity?

Just trying to make sure the quantities are widely used and avoid bloat, we have a small issue with binary size. I could not find much references by a quick google.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not very widely used, but a lot of our stability and control derivatives are in inverse degrees or inverse radians.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have 100+ quantities and 1000+ units, I am hesitant to start adding the inverse variant of all our quantities and units.

We are adding #954 , but that one does seem like a widely used quantity with both wiki article and online converters for.

Are you OK with closing this PR, or do you still see value for others in adding inverse angle?

@mcgougwm mcgougwm closed this Jul 19, 2021
@mcgougwm mcgougwm deleted the Add_InverseAngle branch July 19, 2021 18:32
@angularsen
Copy link
Owner

@mcgougwm I see you deleted the branch so maybe this is a bit late, but I've learned in #954 and #955 that reciprocal angle is also commonly used. So if you are still interested in adding it, I'm happy to merge it.

@angularsen angularsen mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants