Add ReciprocalLength #954
Add ReciprocalLength #954
Conversation
…eract with ReciprocalLength quantity.
…h ReciprocalLength quantity.
…with ReciprocalLength quantity.
…erator overloads for Force and ForcePerLength quantities to interact with ReciprocalLength quantity.
| "Units": [ | ||
| { | ||
| "SingularName": "InverseMeter", | ||
| "PluralName": "InverseMeter", |
| [InlineData(0.0, 0.0)] | ||
| [InlineData(1.0, 1.0)] | ||
| [InlineData(2.0, 0.5)] | ||
| public static void InverseTest(double value, double expected) |
There was a problem hiding this comment.
I see you already copied this test to UnitsNet.Tests/CustomCode/ReciprocalLengthTests.cs, so you can remove this.
There was a problem hiding this comment.
I thought this test was part of the LengthTests so an optical illusion happened for me :). Made this test a part of the LengthTests.
| [InlineData(0.0, 0.0)] | ||
| [InlineData(1.0, 1.0)] | ||
| [InlineData(2.0, 0.5)] | ||
| public static void InverseTest(double value, double expected) |
There was a problem hiding this comment.
Nitpick, but you could rename this InverseReturnsLength.
|
|
||
| protected override double InverseMeterInOneInverseMeter => 1; | ||
| protected override double InverseCentimeterInOneInverseMeter => 1E-2; | ||
| protected override double InverseMillimeterInOneInverseMeter => 1E-3; |
There was a problem hiding this comment.
| protected override double InverseCentimeterInOneInverseMeter => 1E-2; | ||
| protected override double InverseMillimeterInOneInverseMeter => 1E-3; | ||
|
|
||
| protected override double InverseMileInOneInverseMeter => 1 / 0.000621371; |
There was a problem hiding this comment.
Please use constants looked up in an external reference, instead of calculations.
This is meant to serve as a double check that we got it right, since it is very easy to get it inverse and still pass all tests.
According to this converter, InverseMileInOneInverseMeter should be 1609.344.
https://www.unitsconverters.com/en/Reciprocal-Length-Conversions/Measurement-1182
There was a problem hiding this comment.
You're right. I was not sure at the beginning and there is an inconsistency throughout the repo so I've picked the fraction way. Now fixed.
| public partial struct ReciprocalLength | ||
| { | ||
| /// <summary> | ||
| /// Calculates the inverse or <see cref="Length"/> of this unit. |
There was a problem hiding this comment.
Nitpick, but ReciprocalLength is a quantity and not a unit. And since we don't map from InverseYard to Yard, maybe we could describe it like this:
Returns the inverse quantity <see cref="Length"/> with the unit <see cref="LengthUnit.Meter />.
angularsen
changed the title
|
Great work! Nuget is on the way out. |
Added Reciprocal (Inverse) Length quantity and unit.