Add ForceChangeRate arithmetic operators #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't really matter, we have tons of tests on both ctors and factory methods so these tests should focus on the operator overloads. |
|
Sorry, my bad, I read wrong and thought you meant in the tests. |
angularsen
changed the title
angularsen
changed the title
|
Great work, looked perfect to me 🙌 |
|
Nuget should be out shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #989
I added the additional calculation operators for
ForceChangeRate, as agreed in #989.Additionally, I added the appropriate unit tests.
I noticed some differences between creating the new unit in various other operators, where some use the
FromXxx(value)static factory methods and others use the constructors directly.I used the constructors directly to reduce method calls, but I am wondering what is preferred.