Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inaccurate hash information displayed by the --version command #2130

Closed
jonaprieto opened this issue May 25, 2023 · 3 comments · Fixed by #2308
Closed

Remove inaccurate hash information displayed by the --version command #2130

jonaprieto opened this issue May 25, 2023 · 3 comments · Fixed by #2308
Assignees
@paulcadman
Labels
CLI refactor
Milestone
0.4.3

Comments

@jonaprieto
Copy link
Collaborator

The --version command is showing incorrect hash information, causing a lot of confusion during development testing. Let us remove this hash display for the final user, keeping only the version tag. This is good enough and clear for reference. However, I believe keeping this hash for development purposes is nice and desired. Suggestions on how to address this are welcomed.
@jonaprieto jonaprieto added this to the 0.3.5 milestone May 25, 2023
@jonaprieto jonaprieto modified the milestones: 0.3.5, 0.4.1 Jun 1, 2023
@paulcadman paulcadman modified the milestones: 0.4.1, 0.4.2 Jun 23, 2023
@jonaprieto jonaprieto modified the milestones: 0.4.2, 0.4.3 Jul 24, 2023
@paulcadman
Copy link
Collaborator

Proposal: Instead of including the hash in the version, we use the -dev prefix for non-release versions.

Workflow:

  • Release a new version (for example 0.5.0)
  • In the next commit, bump the version and add the -dev prefix, (e.g to 0.5.1-dev)

This would mean we could distinguish between in-progress development versions and release versions.

@paulcadman
Copy link
Collaborator

This is a more significant issue now that obtaining the git info with the gitrev dependency no longer works with the linux release build. #2294

@paulcadman paulcadman self-assigned this Aug 23, 2023
This was referenced Aug 23, 2023
Closed
Merged
@paulcadman
Copy link
Collaborator

I replaced gitrev with githash and this seems to work as expected. So we can keep the hash information.

@paulcadman paulcadman linked a pull request Aug 23, 2023 that will close this issue
Replace gitrev with githash for obtaining build-time git info #2308
Merged
paulcadman added a commit that referenced this issue Aug 23, 2023
@paulcadman
Replace gitrev with githash for obtaining build-time git info (#2308)
06346d1 
This PR replaces [gitrev](https://hackage.haskell.org/package/gitrev)
with [githash](https://hackage.haskell.org/package/githash) which
provides more reliable git information about the current git info, it
seems to work as expected. githash originated as a fork of gitrev
containing fixes snoyberg/githash#11

This PR also fixes the issue with git info detection in the linux static
build. There was a permission issue in the build container that caused
git cli calls to fail.

Closes:
* #2294
* #2130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulcadman paulcadman

Labels
CLI refactor
Projects
None yet
Milestone
0.4.3
Development

Successfully merging a pull request may close this issue.

Replace gitrev with githash for obtaining build-time git info anoma/juvix
3 participants
@paulcadman @jonaprieto @janmasrovira