fix optional prefix iter #1615
Merged
fix optional prefix iter #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/fix-optional-prefix-iter
branch
from
9344eb8
to
d03071c
Compare
Closed
yito88
approved these changes
Jun 26, 2023
Fraccaman
added a commit
that referenced
this pull request
Jun 27, 2023
* origin/tomas/fix-optional-prefix-iter: changelog: add #1615 ledger/storage/rocksdb: refactor prefix iter code ledger/storage/rocksdb: fix iterator without prefix test/ledger/storage/rocksdb: add a test for prefix iter
Closed
This was referenced Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on v0.17.4
The optional prefix iter did nothing when given
Nonefor prefix as shown by the test added in 3bf41d5. The problem was with the upper bound set on the iterator that should only be set when there is a non empty prefix - fixed in 82a07d8. The same issue was already present before changes from #1478 on prefix iter with an empty key (i.e.Key::default()).This affects the rollback command that relies on the iterator with no prefix.