Add a Communication section to README #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @oraNod |
This comment was marked as outdated.
This comment was marked as outdated.
oraNod
reviewed
Sep 10, 2024
Contributor
Author
|
@oraNod committed, thanks, PTAL |
oraNod
approved these changes
Sep 10, 2024
webknjaz
force-pushed
the
irc_remnants
branch
from
4bd6cb1 to
8bc9b88
Compare
webknjaz
reviewed
Sep 11, 2024
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
One of the blocking checks is the missing changelog fragment. Add one, following the surrounding style in https://ansible-pylibssh.rtfd.io/en/latest/changelog/ (past tense et al). Here's an example: 4bd4911#diff-b3c6051ecd8e19ab34e671511fc5e12b70d621bc12dc59d6b8268171fd827f22.
webknjaz
reviewed
Sep 11, 2024
webknjaz
force-pushed
the
irc_remnants
branch
2 times, most recently
from
466b9fc to
f053875
Compare
Andersson007
commented
Sep 11, 2024
psf-chronographer
bot
added
the
bot:chronographer:provided
Contributor
Author
|
the changelog fragment is there, hope it's OK, thanks |
webknjaz
reviewed
Sep 11, 2024
webknjaz
force-pushed
the
irc_remnants
branch
from
2cdef82 to
ebc7672
Compare
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
for more information, see https://pre-commit.ci
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
webknjaz
force-pushed
the
irc_remnants
branch
from
ebc7672 to
7341490
Compare
webknjaz
reviewed
Sep 12, 2024
|
webknjaz
changed the title
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
README: add Communication section
ISSUE TYPE