Fix Session.close() to prevent freeing underlying session

[Jakuje]

SUMMARY

Call to connect() after close() crashed, likely because the NULL pointer was passed somewhere it should not.

The session should really be freed only in the destructor so removing the offending code.

Fixes: #702

ISSUE TYPE

• Bugfix Pull Request

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/ansible-pylibssh-709
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[webknjaz]

@Jakuje does this make it so the underlying session object could persist and would then be reused on reconnect? I guess that's useful. Another way could be having some flag on the session for whether it's still usable.

P.S. I dropped Ubuntu 20.04 on devel so it would be a good idea to rebase now.

[Jakuje]

@Jakuje does this make it so the underlying session object could persist and would then be reused on reconnect? I guess that's useful. Another way could be having some flag on the session for whether it's still usable.

I think the libssh session should be reusable. But I know we had some bugs in the past that were making some operations fail so if we want to be sure, we should add some more extensive tests.

P.S. I dropped Ubuntu 20.04 on devel so it would be a good idea to rebase now.

Will do.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (65ea3a7) to head (a7131a1).
Report is 84 commits behind head on devel.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.