🧪 Generalize cibuildwheel workflow for reusablity #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
webknjaz
force-pushed
the
maintenance/generic-gha-cibuildwheel
branch
3 times, most recently
from
c1c1244 to
b97b240
Compare
webknjaz
added a commit
to webknjaz/ansible--pylibssh
that referenced
this pull request
Jun 23, 2025
psf-chronographer
bot
added
the
bot:chronographer:provided
There was a problem hiding this comment.
Pull Request Overview
Generalize the cibuildwheel workflow to improve reuse and centralize configuration in ci-cd.yml.
- Introduce new inputs (
environment-variables,qemu,runner-vm-os,timeout-minutes) in the reusable workflow - Update default status checks and conditional logic to leverage JSON-parsed inputs
- Refactor
ci-cd.ymljobs to pass all build settings through the newenvironment-variablesinput
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/changelog-fragments/750.contrib.rst | Add entry for refactored reusable-cibuildwheel.yml workflow |
| .github/workflows/reusable-cibuildwheel.yml | Generalize inputs/conditions (environment-variables, qemu, runner-vm-os, timeout-minutes) |
| .github/workflows/ci-cd.yml | Update job invocations to use new inputs and consolidate env vars |
Comments suppressed due to low confidence (2)
.github/workflows/reusable-cibuildwheel.yml:26
- [nitpick] Fix the grammar in the QEMU description; for example: "Whether this job needs to configure QEMU to emulate a foreign architecture before running
cibuildwheel."
Whether this job is needs to configure QEMU to emulate a foreign
.github/workflows/ci-cd.yml:643
- This line sets a macOS-specific variable in a Linux job—consider scoping
CIBW_ARCHS_MACOSto macOS workflows only to avoid confusion.
CIBW_ARCHS_MACOS=native
webknjaz
added a commit
to webknjaz/ansible--pylibssh
that referenced
this pull request
Jun 23, 2025
webknjaz
force-pushed
the
maintenance/generic-gha-cibuildwheel
branch
from
06c4ed4 to
f0a13b5
Compare
webknjaz
added a commit
to webknjaz/ansible--pylibssh
that referenced
this pull request
Jun 23, 2025
webknjaz
force-pushed
the
maintenance/generic-gha-cibuildwheel
branch
from
f0a13b5 to
f8d288e
Compare
webknjaz
force-pushed
the
maintenance/generic-gha-cibuildwheel
branch
from
f8d288e to
7af089e
Compare
|
justin-stephenson
pushed a commit
to justin-stephenson/pylibssh
that referenced
this pull request
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes having input names in line with
reusable-tox.ymland configuringcibuildwheelvia env vars passed through inputs.