-
-
Notifications
You must be signed in to change notification settings - Fork 36
📦🧪 Simplify the RPM spec #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦🧪 Simplify the RPM spec #759
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
9aac810 to
a202289
Compare
|
This is quite large overhaul, but looks like working good (except for some lints). Read through the change and did not notice anything off. |
This patch removes the SRPM-vendored PyPI-sourced dependencies and migrates packaging to rely on `pyproject-rpm-macros` under RHEL. Previously, this set of helpers was only in use on Fedora. This move allows us to get rid of a lot of conditionals that were making people's lives difficult.
a202289 to
a6b1449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the RPM spec file by migrating RHEL packaging to use pyproject-rpm-macros instead of manually vendoring PyPI dependencies. The change aligns RHEL packaging with the existing Fedora approach, eliminating complex conditionals and manual dependency management.
- Removes all vendored PyPI source dependencies from the RPM spec
- Standardizes build process to use
pyproject-rpm-macrosacross all distributions - Simplifies CI/CD workflows by unifying build steps for all distro types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packaging/rpm/ansible-pylibssh.spec | Removes RHEL-specific vendored dependencies and conditionals, adopts unified pyproject build approach |
| .github/workflows/ci-cd.yml | Simplifies CI matrix and build steps, removes distro-specific conditionals |
| docs/changelog-fragments/759.packaging.rst | Documents the RPM spec simplification changes |
| docs/changelog-fragments/759.contrib.rst | Documents the CI/CD workflow improvements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@Jakuje yep, there were a lot of ancient hacks and it took some time testing what can be removed from the spec. It was late yesterday, so I got to finishing minor linting tweaks just today. I'll let it run the CI once more before merging. |
a6b1449 to
b48276a
Compare
This patch removes the SRPM-vendored PyPI-sourced dependencies and migrates packaging to rely on
pyproject-rpm-macrosunder RHEL.Previously, this set of helpers was only in use on Fedora.
This move allows us to get rid of a lot of conditionals that were making people's lives difficult.