Skip to content

Conversation

@webknjaz
Copy link
Member

@webknjaz webknjaz commented Aug 20, 2025

This patch removes the SRPM-vendored PyPI-sourced dependencies and migrates packaging to rely on pyproject-rpm-macros under RHEL.

Previously, this set of helpers was only in use on Fedora.

This move allows us to get rid of a lot of conditionals that were making people's lives difficult.

@webknjaz webknjaz self-assigned this Aug 20, 2025
@webknjaz webknjaz added enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 20, 2025
@webknjaz webknjaz mentioned this pull request Aug 20, 2025
@packit-as-a-service

This comment was marked as outdated.

@webknjaz webknjaz force-pushed the maintenance/ancient-build-in-rpm-spec branch 2 times, most recently from 9aac810 to a202289 Compare August 20, 2025 23:00
@Jakuje
Copy link
Contributor

Jakuje commented Aug 21, 2025

This is quite large overhaul, but looks like working good (except for some lints). Read through the change and did not notice anything off.

This patch removes the SRPM-vendored PyPI-sourced dependencies and
migrates packaging to rely on `pyproject-rpm-macros` under RHEL.

Previously, this set of helpers was only in use on Fedora.

This move allows us to get rid of a lot of conditionals that were
making people's lives difficult.
webknjaz added a commit to webknjaz/ansible--pylibssh that referenced this pull request Aug 21, 2025
@webknjaz webknjaz force-pushed the maintenance/ancient-build-in-rpm-spec branch from a202289 to a6b1449 Compare August 21, 2025 09:48
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 21, 2025
@webknjaz webknjaz marked this pull request as ready for review August 21, 2025 09:49
Copilot AI review requested due to automatic review settings August 21, 2025 09:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the RPM spec file by migrating RHEL packaging to use pyproject-rpm-macros instead of manually vendoring PyPI dependencies. The change aligns RHEL packaging with the existing Fedora approach, eliminating complex conditionals and manual dependency management.

  • Removes all vendored PyPI source dependencies from the RPM spec
  • Standardizes build process to use pyproject-rpm-macros across all distributions
  • Simplifies CI/CD workflows by unifying build steps for all distro types

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packaging/rpm/ansible-pylibssh.spec Removes RHEL-specific vendored dependencies and conditionals, adopts unified pyproject build approach
.github/workflows/ci-cd.yml Simplifies CI matrix and build steps, removes distro-specific conditionals
docs/changelog-fragments/759.packaging.rst Documents the RPM spec simplification changes
docs/changelog-fragments/759.contrib.rst Documents the CI/CD workflow improvements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@webknjaz
Copy link
Member Author

@Jakuje yep, there were a lot of ancient hacks and it took some time testing what can be removed from the spec. It was late yesterday, so I got to finishing minor linting tweaks just today. I'll let it run the CI once more before merging.

@webknjaz webknjaz force-pushed the maintenance/ancient-build-in-rpm-spec branch from a6b1449 to b48276a Compare August 21, 2025 09:52
@webknjaz webknjaz merged commit 811b5a2 into ansible:devel Aug 21, 2025
112 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants