🧪 Narrow SSH command in test helpers to one key #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `ssh` invocations would pick up `$SSH_AUTH_SOCK` and might hang if the agent (like Bitwarden) is awaiting for user input. This patch improves the sshd probe helper responsiveness by disallowing the use of SSH agent, passwords, setting no config and setting a one-second timeout. The command is now narrowly scoped to only use the identity file passed via commandline explicitly.
There was a problem hiding this comment.
Pull Request Overview
This PR improves SSH command configuration in test helpers to prevent hanging when SSH agents await user input. The changes narrow the SSH connection scope to use only the explicitly provided identity file while disabling agent authentication and adding a connection timeout.
Key Changes
- Added strict SSH configuration to disable agent, passwords, and external config files
- Implemented a 1-second connection timeout for faster test failure detection
- Converted short-form SSH flags to explicit
-ooption format for clarity
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
sshinvocations would pick up$SSH_AUTH_SOCKand might hang if the agent (like Bitwarden) is awaiting for user input.This patch improves the sshd probe helper responsiveness by disallowing the use of SSH agent, passwords, setting no config and setting a one-second timeout. The command is now narrowly scoped to only use the identity file passed via commandline explicitly.
ISSUE TYPE
ADDITIONAL INFORMATION
N/A