Fix LUT copying in recursive copy

Author: greschd

src/ansys/acp/core/_recursive_copy.py

@@ -25,6 +25,7 @@
 
 import networkx as nx
 
+from ._tree_objects import LookUpTable1D, LookUpTable1DColumn, LookUpTable3D, LookUpTable3DColumn
 from ._tree_objects._traversal import (
     all_linked_objects,
     child_objects,
@@ -187,6 +188,11 @@ def recursive_copy(
             continue
         tree_object = visited_objects[node]
 
+        if isinstance(tree_object, (LookUpTable1DColumn, LookUpTable3DColumn)):
+            # handled explicitly while copying the LookUpTable object
+            if tree_object.name == "Location":
+                continue
+
         new_tree_object = tree_object.clone()
 
         # If the linked objects are also copied, replace them with the new objects.
@@ -213,8 +219,17 @@ def recursive_copy(
             raise KeyError(
                 f"Parent object not found in 'parent_mapping' for object '{tree_object!r}'."
             ) from exc
+
         new_tree_object.store(parent=new_parent)
 
+        # NOTE: if there are more type-specific fixes needed, we may want
+        # to implement a more generic way to handle these.
+        # Explicit fix for LookUpTable, since the Location column needs to
+        # be set correctly s.t. other columns may be stored.
+        if isinstance(new_tree_object, (LookUpTable1D, LookUpTable3D)):
+            assert isinstance(tree_object, (LookUpTable1D, LookUpTable3D))
+            new_tree_object.columns["Location"].data = tree_object.columns["Location"].data
+
         if include_linked_objects:
             for attr_name, edge_property_list in edge_property_lists(tree_object):
                 new_edge_property_list = [edge.clone() for edge in edge_property_list]

tests/unittests/test_recursive_copy.py

@@ -20,6 +20,7 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+import numpy as np
 import pytest
 
 from ansys.acp.core import FabricWithAngle, recursive_copy
@@ -197,3 +198,32 @@ def test_missing_parent_object_raises(minimal_complete_model):
     msg = str(exc_info.value)
     assert "Parent object" in msg
     assert "parent_mapping" in msg
+
+
+def test_copy_lookup_table_with_columns(minimal_complete_model):
+    """Test copying lookup tables with columns and their data.
+
+    This case is special because LUT implement a check for the shape
+    of the data in their columns, which is determined by the "Location"
+    column.
+    """
+    # GIVEN: a model which has objects with sub-attributes
+    # (here: a lookup table with columns)
+    model = minimal_complete_model
+    lut = model.create_lookup_table_1d()
+    lut.columns["Location"].data = [1.0, 2.0, 3.0]
+    lut.create_column(name="column1", data=[4.0, 5.0, 6.0])
+
+    # WHEN: recursively copying the lookup table
+    new_objects = recursive_copy(source_objects=[lut], parent_mapping=[(model, model)])
+
+    # THEN: the expected new objects are created, but the sub-attributes are
+    # not explicitly copied
+    assert len(new_objects) == 2
+    assert {obj.id for obj in new_objects} == {  # type: ignore
+        "LookUpTable1D.2",
+        "column1",
+    }
+    new_lut = model.lookup_tables_1d["LookUpTable1D.2"]
+    assert np.allclose(new_lut.columns["Location"].data, [1.0, 2.0, 3.0])
+    assert np.allclose(new_lut.columns["column1"].data, [4.0, 5.0, 6.0])