Adapt to Units improvement and Temperature Difference handling #2073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2073 +/- ##
==========================================
+ Coverage 84.13% 86.40% +2.27%
==========================================
Files 90 90
Lines 10303 10303
==========================================
+ Hits 8668 8902 +234
+ Misses 1635 1401 -234 🚀 New features to boost your workflow:
|
PProfizi
reviewed
Feb 17, 2025
| ref = """Static analysis | ||
| if SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_10_0: | ||
| ref = """Static analysis | ||
| Unit system: Custom: m, kg, N, s, V, A, K |
There was a problem hiding this comment.
@TheoMeunierAnsys I' sorry I do not see the difference with the initial reference
…unier/temperature_difference # Conflicts: # tests/test_resultinfo.py
rafacanton
approved these changes
Mar 10, 2025
|
@rafacanton @TheoMeunierAnsys please remember to not put links to TFS in public GH repositories. I removed the one in the description. Thanks! |
|
@TheoMeunierAnsys could we also maybe improve the description here for people who do not have access to the server-side PRs? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to changes induced by a PR in DPF Framework :