Expose shell_layer in animations #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2092 +/- ##
==========================================
+ Coverage 86.39% 86.61% +0.21%
==========================================
Files 90 90
Lines 10240 10250 +10
==========================================
+ Hits 8847 8878 +31
+ Misses 1393 1372 -21 |
PProfizi
changed the title
…onents are reported.
…ral components are reported." This reverts commit 267721d.
PProfizi
force-pushed
the
fix/fields_container_animate_lsdyna
branch
from
5da4f0f to
f16f050
Compare
This reverts commit e47b02b.
3 tasks
rafacanton
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1615
Solves #1435
This PR exposes the
shell_layerselection logic through the animation APIs.It also refactors imports in
mapping_typesas they were preventing me from updating signatures properly.