Skip to content

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Oct 10, 2025

A script using only a LegacyGrpcServer would raise an AttributeError in Field._get_data when trying to create a DPFVectorDouble.
This error type was no longer caught in #2141

@PProfizi PProfizi requested a review from rafacanton October 10, 2025 08:55
@PProfizi PProfizi self-assigned this Oct 10, 2025
@PProfizi PProfizi requested a review from a team as a code owner October 10, 2025 08:55
@PProfizi PProfizi added the bug Something isn't working label Oct 10, 2025
@PProfizi PProfizi linked an issue Oct 10, 2025 that may be closed by this pull request
3 tasks
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Some tests with 'continue-on-error: true' have failed:

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.36%. Comparing base (8d518f6) to head (2c9ef47).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2668      +/-   ##
==========================================
+ Coverage   84.26%   84.36%   +0.10%     
==========================================
  Files          92       92              
  Lines       10858    10858              
==========================================
+ Hits         9149     9160      +11     
+ Misses       1709     1698      -11     

@PProfizi
Copy link
Contributor Author

Waiting for #2669 to have the configuration of the issue covered in the CI and verify that this fixes it.

@PProfizi
Copy link
Contributor Author

PProfizi commented Oct 13, 2025

Fix confirmed.
The fix actually fixes other legacy gRPC tests which were depending on having DPFCLientAPI.dll having been loaded by a previous start of an InProcess server. (such as test_operator_coordinate_system_rst)

@PProfizi PProfizi merged commit 7bc7a1a into main Oct 13, 2025
46 checks passed
@PProfizi PProfizi deleted the fix/get_data_legacy_grpc branch October 13, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in 0.13.7 when extracting data from a field.

2 participants