MAINT: technical review #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@Revathyvenugopal162 @jorgepiloto ... can we have only one PR for this?... |
|
Sure @RobPasMue, we are merging #145 against this one. |
|
Thanks @jorgepiloto - I will wait to review this one in that case. |
* maint: update precommit * maint: update labeler * doc: update contributning * Apply suggestions from code review Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com> * Fix: add labeller for dependency * Doc: fix the header * Doc: fix the vale error * Doc: fix the vale error for sentance case * maint: remove the proto files * Debug: try to remove codecov dependency --------- Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
github-actions
bot
added
dependencies
RobPasMue
approved these changes
Apr 12, 2023
|
|
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
RobPasMue
reviewed
Apr 17, 2023
RobPasMue
approved these changes
Jun 22, 2023
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request introduces all the required changes and updates to pass the technical review of the project according to the PyAnsys guidelines.
Changes include:
pyDynatopydynaANSYS, Inc.AUTHORS.mdcodespellto theaccept.txtfile used by Vale