MAINT: general updates #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
jorgepiloto
requested changes
Apr 12, 2023
| The following contribution information is specific to PyDyna. | ||
|
|
||
| Clone the repository | ||
| -------------------- |
There was a problem hiding this comment.
I am leaving this comment here but it applies to the header in line 2 of this file.
Headers in our chapter must start with the # symbol while sections in chapters use =.
There was a problem hiding this comment.
@jorgepiloto Thanks for pointing that. fixed at a4dbe0e
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
jorgepiloto
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Approving this. Please, fix the warnings on the Vale side @Revathyvenugopal162. We will focus on finishing the tech review in #144.
…yansys/pyDyna into feat/allign-pyansys-guidelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tech review to merge with #144