-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New webhooks playStart, playStop, recordStart issue #4666 #4738
base: master
Are you sure you want to change the base?
Changes from 25 commits
a029073
88444c5
364d9bd
f4ec03a
671f9fa
a59ec87
f7297b1
7b12efc
0f612e8
8d66694
878221c
7534766
daa8baa
6a38708
5919807
a29f692
17a73a9
f68330c
26afa11
9f10b5d
c7fb467
4f6b351
c50d1e9
6b5c02a
f05961f
e25041a
6b8211b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,4 +20,4 @@ temp/ | |
|
||
*.iml | ||
.idea | ||
.fleet | ||
.fleet |
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -2,14 +2,14 @@ | |||||||||||||
|
||||||||||||||
import java.net.InetAddress; | ||||||||||||||
import java.net.UnknownHostException; | ||||||||||||||
import java.util.List; | ||||||||||||||
import java.util.Queue; | ||||||||||||||
|
||||||||||||||
import javax.servlet.Filter; | ||||||||||||||
import javax.servlet.FilterConfig; | ||||||||||||||
import javax.servlet.ServletException; | ||||||||||||||
import javax.servlet.http.HttpServletRequest; | ||||||||||||||
|
||||||||||||||
import io.antmedia.AntMediaApplicationAdapter; | ||||||||||||||
import org.apache.catalina.util.NetMask; | ||||||||||||||
import org.slf4j.Logger; | ||||||||||||||
import org.slf4j.LoggerFactory; | ||||||||||||||
|
@@ -163,5 +163,16 @@ public Broadcast getBroadcast(HttpServletRequest request, String streamId) { | |||||||||||||
} | ||||||||||||||
return broadcast; | ||||||||||||||
} | ||||||||||||||
|
||||||||||||||
protected AntMediaApplicationAdapter getAntMediaApplicationAdapter(){ | ||||||||||||||
AntMediaApplicationAdapter antMediaApplicationAdapter = null; | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Var: Non-constant variable missing @var annotation
Suggested change
ℹ️ Learn about @sonatype-lift commandsYou can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Note: When talking to LiftBot, you need to refresh the page to see its response. Was this a good recommendation? |
||||||||||||||
ApplicationContext context = getAppContext(); | ||||||||||||||
if (context != null) | ||||||||||||||
{ | ||||||||||||||
antMediaApplicationAdapter= (AntMediaApplicationAdapter)context.getBean(AntMediaApplicationAdapter.BEAN_NAME); | ||||||||||||||
} | ||||||||||||||
return antMediaApplicationAdapter; | ||||||||||||||
|
||||||||||||||
} | ||||||||||||||
|
||||||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THREAD_SAFETY_VIOLATION: Unprotected write. Non-private method
AntMediaApplicationAdapter.sendStartPlayWebHook(...)
indirectly writes to fieldthis.dataStore
outside of synchronization.Reporting because another access to the same memory occurs on a background thread, although this access may not.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
@sonatype-lift ignore
@sonatype-lift ignoreall
@sonatype-lift exclude <file|issue|path|tool>
file|issue|path|tool
from Lift findings by updating your config.toml fileNote: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]