Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily 0402 #2262

Merged
merged 9 commits into from
Apr 3, 2020
Merged

Daily 0402 #2262

merged 9 commits into from
Apr 3, 2020

Conversation

simaQ
Copy link
Contributor

@simaQ simaQ commented Apr 2, 2020

Closed #2251
Closed #2258

同时修复主题更新后,Geometry 没有更新的问题。

@auto-add-label auto-add-label bot added the WIP label Apr 2, 2020
@todo
Copy link

todo bot commented Apr 2, 2020

测试点图需要更新

// todo 测试点图需要更新
});
});


This comment was generated by todo based on a todo comment in f2cf7c6 in #2262. cc @antvis.

@lgtm-com
Copy link

lgtm-com bot commented Apr 2, 2020

This pull request fixes 1 alert when merging be5e491 into 3ae581b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@simaQ simaQ changed the title WIP: Daily 0402 Daily 0402 Apr 2, 2020
@simaQ simaQ requested a review from hustcc April 2, 2020 09:50
@simaQ simaQ removed the WIP label Apr 2, 2020
@simaQ simaQ added this to the v4.0.4 milestone Apr 2, 2020
@lgtm-com
Copy link

lgtm-com bot commented Apr 2, 2020

This pull request fixes 1 alert when merging 1d68d4d into 3ae581b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 2, 2020

This pull request fixes 1 alert when merging 64d4e70 into 59db3b5 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@hustcc
Copy link
Member

hustcc commented Apr 2, 2020

  1. getThemeByStylesheet, getTheme 连个方法名感觉容易产生曲解, getThemeByStylesheet -> createThemeByStylesheet

  2. getThemeByStylesheet 还有必要 export 出来吗,理论上是给内部使用就够了吧~

@simaQ
Copy link
Contributor Author

simaQ commented Apr 2, 2020

  1. createThemeByStylesheet

改好了呢!

@lgtm-com
Copy link

lgtm-com bot commented Apr 2, 2020

This pull request fixes 1 alert when merging 84a15a2 into 1f9b96b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc merged commit c35b848 into master Apr 3, 2020
@hustcc hustcc deleted the daily-0402 branch April 3, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x 如何注册主题, 如何动态切换主题 4.0.2 主题配置并没生效
2 participants