Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复axis grid的callback配置方式 #261

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

lessmost
Copy link
Member

这里之前是允许整个grid是个callback,调整下还是保持gird.visible的结构,运行grid.style通过callback配置

@auto-add-label auto-add-label bot added the Bug Something isn't working label Nov 18, 2019
@todo
Copy link

todo bot commented Nov 18, 2019

g 提供详细style的类型定义

https://github.com/antvis/g2plot/blob/cd64f1d8c19f416ca5f29c161c5886ff207f100b/src/interface/config.ts#L30-L35


This comment was generated by todo based on a TODO comment in cd64f1d in #261. cc @antvis.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 18, 2019

Deploy preview for antv-g2plot ready!

Built with commit cd64f1d

https://deploy-preview-261--antv-g2plot.netlify.com

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2019

This pull request introduces 1 alert when merging cd64f1d into f9c7c56 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@paleface001 paleface001 merged commit 440f5d7 into master Nov 18, 2019
@paleface001 paleface001 deleted the fix-axis-grid-callback-cfg branch November 18, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants