Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React #216

Merged
merged 6 commits into from
Feb 19, 2020
Merged

React #216

merged 6 commits into from
Feb 19, 2020

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Feb 19, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@todo
Copy link

todo bot commented Feb 19, 2020

Shape 更新重新build

(shape && shape.needRegenerateVertices) // TODO:Shape 更新重新build
) {
layer.layerModelNeedUpdate = true;
attributes.forEach((attr) => (attr.needRegenerateVertices = false));
return;


This comment was generated by todo based on a TODO comment in c7405b1 in #216. cc @antvis.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link

lgtm-com bot commented Feb 19, 2020

This pull request introduces 13 alerts when merging c7405b1 into 0677776 - view on LGTM.com

new alerts:

  • 13 for Unused variable, import, function or class

@lzxue lzxue merged commit 1d3dd58 into master Feb 19, 2020
@lzxue lzxue deleted the react branch February 19, 2020 16:31
@todo todo bot mentioned this pull request Feb 19, 2020
lzxue added a commit that referenced this pull request Mar 5, 2020
lzxue added a commit that referenced this pull request Mar 5, 2020
lzxue added a commit that referenced this pull request Mar 5, 2020
lzxue added a commit that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant