Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L7 draw #257

Merged
merged 6 commits into from
Mar 20, 2020
Merged

L7 draw #257

merged 6 commits into from
Mar 20, 2020

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Mar 20, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

tests-checker[bot]
tests-checker bot suggested changes Mar 20, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@todo
Copy link

todo bot commented Mar 20, 2020

DEMONSTRATE API

L7/packages/draw/README.md

Lines 10 to 11 in 54ba388

// TODO: DEMONSTRATE API
```

This comment was generated by todo based on a TODO comment in 54ba388 in #257. cc @antvis.

@lgtm-com
Copy link

lgtm-com bot commented Mar 20, 2020

This pull request introduces 1 alert when merging 896ce3c into 6730b38 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 20, 2020

This pull request introduces 6 alerts when merging df385d9 into 6730b38 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

@antvis antvis deleted a comment from todo bot Mar 20, 2020
@lgtm-com
Copy link

lgtm-com bot commented Mar 20, 2020

This pull request introduces 6 alerts when merging 9eb4c6f into 6730b38 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

@lzxue lzxue merged commit ccf63d0 into master Mar 20, 2020
@lzxue lzxue deleted the l7-draw branch March 20, 2020 03:49
lzxue added a commit that referenced this pull request Apr 13, 2020
@lzxue
Merge pull request #257 from antvis/l7-draw
c84fa7d 
L7 draw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lzxue