Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layers): add polygon3d , pointimagelayer #49

Merged
merged 5 commits into from
Oct 30, 2019
Merged

feat(layers): add polygon3d , pointimagelayer #49

merged 5 commits into from
Oct 30, 2019

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Oct 30, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@auto-add-label auto-add-label bot added the help wanted issue 求助社区帮助解决 label Oct 30, 2019
@todo
Copy link

todo bot commented Oct 30, 2019

new GeoJSONSource()

// TODO: new GeoJSONSource()
layer
.source(await response.json())
.size('name', [0, 10000, 50000, 30000, 100000])
.color('name', [
'#2E8AE6',


This comment was generated by todo based on a TODO comment in bda6b6c in #49. cc @antvis.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2019

This pull request introduces 9 alerts and fixes 1 when merging ac2548e into b370b7b - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class
  • 3 for Syntax error

fixed alerts:

  • 1 for Unused variable, import, function or class

@lzxue lzxue merged commit 91cef61 into next Oct 30, 2019
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2019

This pull request introduces 7 alerts and fixes 1 when merging 8a615e6 into b370b7b - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lzxue added a commit that referenced this pull request Mar 5, 2020
feat(layers): add polygon3d , pointimagelayer
lzxue added a commit that referenced this pull request Mar 6, 2020
feat(layers): add polygon3d , pointimagelayer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issue 求助社区帮助解决 PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant