Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flowchart connection #32

Merged
merged 29 commits into from
Dec 13, 2019
Merged

feat: flowchart connection #32

merged 29 commits into from
Dec 13, 2019

Conversation

bubkoo
Copy link
Member

@bubkoo bubkoo commented Dec 12, 2019

Description

增强连线交互

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@auto-add-label auto-add-label bot added the type: feature 新功能 Feature/enhancement requests label Dec 12, 2019
@pr-triage pr-triage bot added the PR: unreviewed PR does not have any reviews. label Dec 12, 2019
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot added PR: reviewed-changes-requested PR has reviewed and got Change request event. and removed PR: unreviewed PR does not have any reviews. labels Dec 12, 2019
@github-actions github-actions bot added PR(feature) :tada: New feature pkg:x6 labels Dec 12, 2019
@pr-triage pr-triage bot added PR: unreviewed PR does not have any reviews. and removed PR: reviewed-changes-requested PR has reviewed and got Change request event. labels Dec 12, 2019
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 13, 2019

This pull request introduces 1 alert when merging 319efa6 into 8b6bb9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 13, 2019

This pull request introduces 1 alert when merging 9935fa9 into 8b6bb9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

auto adsorb nearest anchor when find an edge's target anchor
default use ellipse as an anchor shape

fix #39
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 13, 2019

This pull request introduces 1 alert when merging db6a870 into 8b6bb9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 13, 2019

This pull request introduces 1 alert when merging efa08e4 into 8b6bb9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@bubkoo bubkoo merged commit 79c195d into master Dec 13, 2019
@bubkoo bubkoo deleted the feature/flowchart-conn branch December 13, 2019 17:58
@pr-triage pr-triage bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Dec 13, 2019
@antvis antvis deleted a comment from x6-bot bot Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR(feature) :tada: New feature PR: merged PR has merged. type: feature 新功能 Feature/enhancement requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant