Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate rank total_value mistake #1029

Closed
cmougan opened this issue Apr 28, 2021 · 1 comment
Closed

calculate rank total_value mistake #1029

cmougan opened this issue Apr 28, 2021 · 1 comment

Comments

@cmougan
Copy link

cmougan commented Apr 28, 2021

In the file src/calculateRank.js:

const RANK_S_VALUE = 1;
  const RANK_DOUBLE_A_VALUE = 25;
  const RANK_A2_VALUE = 45;
  const RANK_A3_VALUE = 60;
  const RANK_B_VALUE = 100;

  const TOTAL_VALUES =
    RANK_S_VALUE + RANK_A2_VALUE + RANK_A3_VALUE + RANK_B_VALUE;

Should not it be

  const TOTAL_VALUES =
    RANK_S_VALUE + RANK_DOUBLE_A_VALUE + RANK_A2_VALUE + RANK_A3_VALUE + RANK_B_VALUE;
@anuraghazra
Copy link
Owner

Thanks for opening the issue, closing via #1031 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants