Rank doesn't take into account whether include_all_commits is taken into account #1260
Labels
enhancement
New feature or request.
ranks
Feature, Bug fix, improvement related to ranking system.
stats-card
Feature, Enhancement, Fixes related to stats the stats card.
Describe the bug
What is passed to the
calculateRank
function depends on whetherinclude_all_commits
was orignally true or not.So if you pass include_all_commits=True you generally get a much better rank than if you do not.
In my case normal commits (for the current year) was ~2000 giving me an A++ rank. If I use include_all_commits=true then 12000 is passed and I get an S rank.
github-readme-stats/src/fetchers/stats-fetcher.js
Lines 119 to 142 in 7907a5d
Expected behavior
one of these two values (total for the year, or total for all periods) should be passed to the function probably.
Screenshots / Live demo link (paste the github-readme-stats link as markdown image)
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: