Skip to content
This repository was archived by the owner on Feb 25, 2019. It is now read-only.

Conversation

hovenko
Copy link
Contributor

@hovenko hovenko commented Oct 19, 2018

Adds some documentation that this module cannot be used with Webpack.

Related to solid/solid#217 and #79

@dmitrizagidulin
Copy link
Member

Thanks @hovenko!

Hey, any chance you can also include 'text-encoding': 'TextEncoder' to that list of externals, while you're at it? (That's also a server-side shim that this lib uses, that is present in the browser.)

@hovenko
Copy link
Contributor Author

hovenko commented Oct 20, 2018

I can do that, but my intent was to show how to externalize this library, independent of any other libraries that this module depends on and use.

If one don't use text-encoding (directly) then I think it's not relevant for users of webcrypto/crypto to think about externalizing it...

What do you think?

(I hit the wrong post button and accidentally closed it. Got it reopened.)

@hovenko hovenko closed this Oct 20, 2018
@hovenko hovenko reopened this Oct 20, 2018
@dmitrizagidulin
Copy link
Member

I vaguely recall that Webpack includes that library anyways, when excluding webcrypto, but I could be wrong. K, no worries then, thanks again.

@dmitrizagidulin dmitrizagidulin merged commit 5303c62 into anvilresearch:master Oct 21, 2018
@hovenko
Copy link
Contributor Author

hovenko commented Oct 21, 2018

I don't know the inner details of Webpack, but that sounds to my like a strange and (I guess) unwanted behavior.

But when including rdflib for example, then the TextEncoding library might be included transitively by one of the other libraries in that dependency tree, even when webcrypto is externalized. It's on my todo-list to write this kind of documentation to the other libraries used by Solid apps. :)

@hovenko hovenko deleted the documents_webpack_usage branch November 10, 2018 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants