Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler: throttle thread queueing by CUs #1101

Merged
merged 1 commit into from
May 7, 2024

Conversation

apfitzge
Copy link

Problem

  • Scheduler queues up more work than necessary which can lead to more work being queued due to account conflicts

Summary of Changes

  • CU limits are now more reasonable, with much lower estimated/actual ratios than the previous scheduler
  • Can now use CUs to throttle the scheduled work queues so we don't queue up too much work

Fixes #

@apfitzge apfitzge marked this pull request as ready for review May 6, 2024 19:37
@apfitzge apfitzge requested a review from tao-stones May 6, 2024 19:37
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good idea to limit number of TXs to be scheduled at once. Just few small questions.

Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for clarifying the intent

@apfitzge apfitzge merged commit ec54b01 into anza-xyz:master May 7, 2024
38 checks passed
@apfitzge apfitzge added the v1.18 label May 7, 2024
Copy link

mergify bot commented May 7, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request May 7, 2024
yihau pushed a commit that referenced this pull request May 9, 2024
…#1220)

Scheduler: throttle thread queueing by CUs (#1101)

(cherry picked from commit ec54b01)

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
@apfitzge apfitzge deleted the scheduler_cu_throttle branch May 9, 2024 16:06
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…yz#1101) (anza-xyz#1220)

Scheduler: throttle thread queueing by CUs (anza-xyz#1101)

(cherry picked from commit ec54b01)

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants