Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: Scheduler: throttle thread queueing by CUs (backport of #1101) #1220

Merged
merged 1 commit into from
May 9, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 7, 2024

Problem

  • Scheduler queues up more work than necessary which can lead to more work being queued due to account conflicts

Summary of Changes

  • CU limits are now more reasonable, with much lower estimated/actual ratios than the previous scheduler
  • Can now use CUs to throttle the scheduled work queues so we don't queue up too much work

Fixes #


This is an automatic backport of pull request #1101 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner May 7, 2024 13:55
@mergify mergify bot requested a review from a team as a code owner May 7, 2024 13:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.6%. Comparing base (a73b6cb) to head (db9f8e6).

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.18    #1220     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         827      827             
  Lines      225352   225363     +11     
=========================================
+ Hits       184043   184047      +4     
- Misses      41309    41316      +7     

@apfitzge apfitzge requested a review from tao-stones May 8, 2024 19:37
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - clean backporting.

@yihau yihau merged commit be4a672 into v1.18 May 9, 2024
35 checks passed
@yihau yihau deleted the mergify/bp/v1.18/pr-1101 branch May 9, 2024 11:02
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…yz#1101) (anza-xyz#1220)

Scheduler: throttle thread queueing by CUs (anza-xyz#1101)

(cherry picked from commit ec54b01)

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants